cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

allstacks: improve buffer alloc sizing and adopt more widely

Open tbg opened this issue 4 weeks ago • 1 comments

In an escalation^1, we observed that on larger clusters, multiple rounds of runtime.Stacks are required until the buffer sizing algorithm as produced a large enough buffer. Since grabbing stacks will cause stop-the-world pauses, this is best avoided.

NB: *serverpb.StacksRequest is already populated using allstacks.Get.

Epic: none

tbg avatar Dec 11 '25 15:12 tbg

This change is Reviewable

cockroach-teamcity avatar Dec 11 '25 15:12 cockroach-teamcity

TFTR!

bors r+

tbg avatar Dec 12 '25 15:12 tbg

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 480248d3b3385fd4d6c8da27cdb5d1e4f744b94d to blathers/backport-release-24.3-159279: POST https://api.github.com/repos/tbg/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch release-24.3 failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Dec 12 '25 17:12 blathers-crl[bot]