cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

cli/debug: narrow scope of --include-goroutine-stacks to just debug=2

Open dt opened this issue 4 weeks ago • 6 comments

Release note: none. Epic: none.

dt avatar Dec 11 '25 13:12 dt

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Dec 11 '25 13:12 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Dec 11 '25 13:12 cockroach-teamcity

debug 3

Not yet: adding that is what had me in the neighborhood to notice this, but wanted to fix this one standalone in case it wants a backport later

dt avatar Dec 11 '25 13:12 dt

debug=3

https://github.com/cockroachdb/cockroach/pull/159260

dt avatar Dec 11 '25 13:12 dt

TFTR!

bors r+

dt avatar Dec 11 '25 16:12 dt

@dhartunian How do you feel about backports to released branches in the interest of improving supportability (making --include-goroutine-stacks=false less costly in terms of debugging information lost and thus more viable as a latency-impact-reduction tool)?

dt avatar Dec 11 '25 16:12 dt

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating backport branch refs/heads/blathers/backport-release-26.1-159253: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch 26.1.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Dec 11 '25 17:12 blathers-crl[bot]

blathers backport 26.1

dt avatar Dec 15 '25 20:12 dt