cockroachdb
kvserver: lower slow latch request threshold to 2s for nodeliveness rng
The default value of SlowLatchRequestThreshold is 5s, but since liveness heartbeats timeout after 3 seconds, its preferable to lower the threshold for the liveness range. This ensures that there will be logging/metrics for slow latch requests on this range before the request times out.
Fixes https://github.com/cockroachdb/cockroach/issues/154271 Release note: None Epic: None Part of: CRDB-54843
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?
:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.
![blathers-crl[bot] avatar](https://avatars.githubusercontent.com/in/59700?v=4 "Published by a pub.dev verified publisher"){kind=small}
Previously, arulajmani (Arul Ajmani) wrote…
Can we close this out with this patch, or is there more left?
I think we can close it, updated to "Fixes"
Potential Bug(s) Detected
The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.
Next Steps: Please review the detailed findings in the workflow run.
Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.
After you review the findings, please tag the issue as follows:
- If the detected issue is real or was helpful in any way, please tag the issue with
O-AI-Review-Real-Issue-Found - If the detected issue was not helpful in any way, please tag the issue with
O-AI-Review-Not-Helpful
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Potential Bug(s) Detected
The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.
Next Steps: Please review the detailed findings in the workflow run.
Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.
After you review the findings, please tag the issue as follows:
- If the detected issue is real or was helpful in any way, please tag the issue with
O-AI-Review-Real-Issue-Found - If the detected issue was not helpful in any way, please tag the issue with
O-AI-Review-Not-Helpful
Potential Bug(s) Detected
The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.
Next Steps: Please review the detailed findings in the workflow run.
Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.
After you review the findings, please tag the issue as follows:
- If the detected issue is real or was helpful in any way, please tag the issue with
O-AI-Review-Real-Issue-Found - If the detected issue was not helpful in any way, please tag the issue with
O-AI-Review-Not-Helpful
Potential Bug(s) Detected
The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.
Next Steps: Please review the detailed findings in the workflow run.
Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.
After you review the findings, please tag the issue as follows:
- If the detected issue is real or was helpful in any way, please tag the issue with
O-AI-Review-Real-Issue-Found - If the detected issue was not helpful in any way, please tag the issue with
O-AI-Review-Not-Helpful
the ai review thinks i need to use the mutex around Manager.slowLatchRequestThresholdOverride. It claims that ./dev test pkg/kv/kvserver/spanlatch --race will show the presence of this bug, but i ran that and it seemed fine. I'm inclined to think the mutex is unnecessary but curious to get a second opinion.
Potential Bug(s) Detected
The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.
Next Steps: Please review the detailed findings in the workflow run.
Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.
After you review the findings, please tag the issue as follows:
- If the detected issue is real or was helpful in any way, please tag the issue with
O-AI-Review-Real-Issue-Found - If the detected issue was not helpful in any way, please tag the issue with
O-AI-Review-Not-Helpful
Potential Bug(s) Detected
The three-stage Claude Code analysis has identified potential bug(s) in this PR that may warrant investigation.
Next Steps: Please review the detailed findings in the workflow run.
Note: When viewing the workflow output, scroll to the bottom to find the Final Analysis Summary.
After you review the findings, please tag the issue as follows:
- If the detected issue is real or was helpful in any way, please tag the issue with
O-AI-Review-Real-Issue-Found - If the detected issue was not helpful in any way, please tag the issue with
O-AI-Review-Not-Helpful
![craig[bot] avatar](https://avatars.githubusercontent.com/in/10419?v=4 "Published by a pub.dev verified publisher"){kind=small}
bors r+
CI flake is TestAlterChangefeedAddTargetsDuringBackfill - already fixed afaict and unrelated to this PR.
Build succeeded:
- linux_amd64_build
- examples_orms
- unit_tests
- docker_image_amd64
- local_roachtest
- check_generated_code
- local_roachtest_fips
- acceptance
- linux_amd64_fips_build
- lint