cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

benchprof: fix nil pointer exception

Open mgartner opened this issue 6 months ago • 2 comments

A bug in benchprof.StartAllProfiles has been fixed that caused nil pointer exceptions. Additionally, benchprof.StartAllProfiles no longer allocates a do-nothing StopFn.

Release note: None

mgartner avatar Jun 17 '25 20:06 mgartner

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Jun 17 '25 20:06 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Jun 17 '25 20:06 cockroach-teamcity

TFTR!

bors r+

mgartner avatar Jun 18 '25 23:06 mgartner