cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

build, microbench-ci: update token retrieval

Open herkolategan opened this issue 6 months ago • 6 comments

This change updates the token retrieval to use gcloud instead of relying on target_pull_request to provide a token with the required permissions, to add labels or post to a PR.

Epic: None Release note: None

herkolategan avatar Jun 12 '25 08:06 herkolategan

This change is Reviewable

cockroach-teamcity avatar Jun 12 '25 08:06 cockroach-teamcity

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Jun 13 '25 11:06 blathers-crl[bot]

🔴 Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
🔴 sec/op 8.572m ±1% 8.834m ±1% +3.06% p=0.000 n=15
🔴 allocs/op 9.480k ±0% 10.15k ±1% +7.05% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/13731b4/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/13731b4e0e867d024bee02f596eea1371bae6de8/bin/pkg_sql_tests benchdiff/13731b4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/13731b4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=2c99066 --new=13731b4 ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 1.067m ±1% 1.141m ±1% +6.92% p=0.000 n=15
🔴 allocs/op 1.857k ±0% 2.096k ±0% +12.87% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/13731b4/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/13731b4e0e867d024bee02f596eea1371bae6de8/bin/pkg_sql_tests benchdiff/13731b4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/13731b4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=2c99066 --new=13731b4 ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 1.921m ±1% 2.012m ±0% +4.74% p=0.000 n=15
🔴 allocs/op 3.791k ±0% 4.185k ±0% +10.39% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/13731b4/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/13731b4e0e867d024bee02f596eea1371bae6de8/bin/pkg_sql_tests benchdiff/13731b4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/13731b4/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=2c99066 --new=13731b4 ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/13731b4e0e867d024bee02f596eea1371bae6de8/15633723892-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/2c99066211911e14c7519ec47a5c021488a1fe71/15633723892-1/\* old/

built with commit: 13731b4e0e867d024bee02f596eea1371bae6de8

github-actions[bot] avatar Jun 13 '25 12:06 github-actions[bot]

🔴 Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
🔴 sec/op 8.507m ±0% 8.775m ±0% +3.15% p=0.000 n=15
🔴 allocs/op 9.468k ±2% 10.14k ±1% +7.09% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c9f6d73/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9f6d738087afafd540efb7ba5122a558c001557/bin/pkg_sql_tests benchdiff/c9f6d73/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9f6d73/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=2c99066 --new=c9f6d73 ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 1.075m ±1% 1.156m ±2% +7.62% p=0.000 n=15
🔴 allocs/op 1.857k ±0% 2.097k ±0% +12.92% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c9f6d73/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9f6d738087afafd540efb7ba5122a558c001557/bin/pkg_sql_tests benchdiff/c9f6d73/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9f6d73/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=2c99066 --new=c9f6d73 ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 1.915m ±1% 2.000m ±0% +4.42% p=0.000 n=15
🔴 allocs/op 3.790k ±0% 4.182k ±0% +10.34% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c9f6d73/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c9f6d738087afafd540efb7ba5122a558c001557/bin/pkg_sql_tests benchdiff/c9f6d73/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c9f6d73/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=2c99066 --new=c9f6d73 ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/c9f6d738087afafd540efb7ba5122a558c001557/15638329893-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/2c99066211911e14c7519ec47a5c021488a1fe71/15638329893-1/\* old/

built with commit: c9f6d738087afafd540efb7ba5122a558c001557

github-actions[bot] avatar Jun 13 '25 16:06 github-actions[bot]

🔴 Sysbench [SQL, 3node, oltp_read_write]
Metric Old Commit New Commit Delta Note
🔴 sec/op 8.416m ±0% 8.696m ±0% +3.33% p=0.000 n=15
🔴 allocs/op 9.443k ±0% 10.10k ±1% +6.90% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c92abdc/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c92abdc71850f94fc69cc6e6453605c3896dc280/bin/pkg_sql_tests benchdiff/c92abdc/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c92abdc/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/SQL/3node/oltp_read_write$ --old=2c99066 --new=c92abdc ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_read_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 1.057m ±1% 1.120m ±1% +5.97% p=0.000 n=15
🔴 allocs/op 1.857k ±0% 2.096k ±0% +12.87% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c92abdc/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c92abdc71850f94fc69cc6e6453605c3896dc280/bin/pkg_sql_tests benchdiff/c92abdc/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c92abdc/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_read_only$ --old=2c99066 --new=c92abdc ./pkg/sql/tests
🔴 Sysbench [KV, 3node, oltp_write_only]
Metric Old Commit New Commit Delta Note
🔴 sec/op 1.911m ±0% 2.002m ±1% +4.75% p=0.000 n=15
🔴 allocs/op 3.792k ±0% 4.186k ±0% +10.39% p=0.000 n=15
Reproduce

benchdiff binaries:

mkdir -p benchdiff/c92abdc/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/c92abdc71850f94fc69cc6e6453605c3896dc280/bin/pkg_sql_tests benchdiff/c92abdc/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/c92abdc/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
mkdir -p benchdiff/2c99066/bin/1058449141
gcloud storage cp gs://cockroach-microbench-ci/builds/2c99066211911e14c7519ec47a5c021488a1fe71/bin/pkg_sql_tests benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests
chmod +x benchdiff/2c99066/bin/1058449141/cockroachdb_cockroach_pkg_sql_tests

benchdiff command:

benchdiff --run=^BenchmarkSysbench/KV/3node/oltp_write_only$ --old=2c99066 --new=c92abdc ./pkg/sql/tests
Artifacts

download:

mkdir -p new
gcloud storage cp gs://cockroach-microbench-ci/artifacts/c92abdc71850f94fc69cc6e6453605c3896dc280/15674654280-1/\* new/
mkdir -p old
gcloud storage cp gs://cockroach-microbench-ci/artifacts/2c99066211911e14c7519ec47a5c021488a1fe71/15674654280-1/\* old/

built with commit: c92abdc71850f94fc69cc6e6453605c3896dc280

cockroach-teamcity avatar Jun 16 '25 08:06 cockroach-teamcity

cockroach-teamcity

Latest post is from the new token (added a regression to trigger it, which is now removed for the final merge).

The build sections of this PR already curate what they check out, hence it didn't need updating after changing the target, which also changes the defaults for the checkout action.

herkolategan avatar Jun 16 '25 09:06 herkolategan

TFTR!

bors r=rail

herkolategan avatar Jun 23 '25 12:06 herkolategan