cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

kvserver/rangefeed: add metrics for lockedMuxStream.Send calls

Open xuchef opened this issue 5 months ago • 2 comments
trafficstars

Adds observability into the latency of lockedMuxStream.Send with a histogram metric that uses the IOLatencyBuckets bucket configuration (see https://github.com/cockroachdb/cockroach/pull/147440#discussion_r2112420050).

Also adds a counter for the number of slow sends, using the same criteria as the log line added in https://github.com/cockroachdb/cockroach/pull/146765.

Resolves: https://github.com/cockroachdb/cockroach/issues/147435 Epic: CRDB-51061 Release note: None

xuchef avatar May 28 '25 16:05 xuchef

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 28 '25 16:05 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar May 28 '25 17:05 cockroach-teamcity

bors r=wenyihu6

xuchef avatar Jun 20 '25 14:06 xuchef