cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

admission: do not create snapshot pacer for nil queue

Open aadityasondhi opened this issue 1 year ago • 1 comments

Even though Pace() was checking for nil snapshot queue, it was asserting on the snapshotRequester interface, which would be non-nil even if the underlying queue was nil.

This patch moves the nil check outside of the pacer, and we don't create a pacer if the snapshot queue is nil.

Also, the Close() func was not doing any real work, so we remove that.

Fixes #132905.

Release note: None

aadityasondhi avatar Oct 18 '24 18:10 aadityasondhi

This change is Reviewable

cockroach-teamcity avatar Oct 18 '24 18:10 cockroach-teamcity

Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches.


Issue #132905: branch-release-24.3.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Oct 21 '24 16:10 blathers-crl[bot]