cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

admission: do not create snapshot pacer for nil queue

Open aadityasondhi opened this issue 4 months ago • 1 comments

Even though Pace() was checking for nil snapshot queue, it was asserting on the snapshotRequester interface, which would be non-nil even if the underlying queue was nil.

This patch moves the nil check outside of the pacer, and we don't create a pacer if the snapshot queue is nil.

Also, the Close() func was not doing any real work, so we remove that.

Fixes #132905.

Release note: None

aadityasondhi avatar Oct 18 '24 18:10 aadityasondhi