cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

sql,server: execute update table metadata job on chan notify

Open xinhaoz opened this issue 1 year ago • 1 comments

This commit allows the update table metadata BG job to execute a run when signalled via a channel. Currently, the channel is passed to the statusServer which notifies the job via the newly added gRPC method, UpdateTableMetadataCache, which forwards the request to the node owning the job.

Summary:

  • Added UpdateTableMetadataCache grpc method on status server forwards request to node with update table metadata cache job.
  • Update table metadata cache job observes channel to start execution.
  • On every execution, the update job now increments the num runs metric.

Part of: https://github.com/cockroachdb/cockroach/issues/128993 Release note: None

xinhaoz avatar Aug 28 '24 21:08 xinhaoz

This change is Reviewable

cockroach-teamcity avatar Aug 28 '24 21:08 cockroach-teamcity

Just realized my crlfmt has been broken 🫠

xinhaoz avatar Sep 04 '24 20:09 xinhaoz

@stevendanna Any additional comments before I merge this?

xinhaoz avatar Sep 05 '24 20:09 xinhaoz

bors r+

xinhaoz avatar Sep 06 '24 17:09 xinhaoz