cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

crosscluster: use fully qualified table names as targets

Open azhu-crl opened this issue 1 year ago • 1 comments

This PR updates the targets column returned by SHOW LDR jobs commands. targets should now show fully qualified table names.

Example output:

[email protected]:26257/demoapp/b> SHOW LOGICAL REPLICATION JOBS;
        job_id       | status  |    targets     | replicated_time
---------------------+---------+----------------+------------------
  998783553025802241 | running | {a.public.tab} | NULL
  998783553070432257 | running | {b.public.tab} | NULL
(2 rows)

Time: 22ms total (execution 21ms / network 1ms)

[email protected]:26257/demoapp/b> SHOW LOGICAL REPLICATION JOBS WITH DETAILS;
        job_id       | status  |    targets     |        replicated_time        |    replication_start_time     | conflict_resolution_type |                                                                                             description
---------------------+---------+----------------+-------------------------------+-------------------------------+--------------------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
  998783553025802241 | running | {a.public.tab} | 2024-08-28 19:55:51.091169+00 | 2024-08-28 19:55:51.091169+00 | DLQ                      | LOGICAL REPLICATION STREAM into a.public.tab from postgresql://demo:[email protected]:26257/b?options=-ccluster%3Ddemoapp&sslmode=require&sslrootcert=%2FUsers%2Fannezhu%2F.cockroach-demo%2Fca.crt
  998783553070432257 | running | {b.public.tab} | 2024-08-28 19:55:51.105285+00 | 2024-08-28 19:55:51.105285+00 | DLQ                      | LOGICAL REPLICATION STREAM into b.public.tab from postgresql://demo:[email protected]:26257/a?options=-ccluster%3Ddemoapp&sslmode=require&sslrootcert=%2FUsers%2Fannezhu%2F.cockroach-demo%2Fca.crt
(2 rows)

Time: 16ms total (execution 16ms / network 1ms)

Epic: none Informs: https://github.com/cockroachdb/cockroach/issues/128960 Release note: none

azhu-crl avatar Aug 28 '24 20:08 azhu-crl

This change is Reviewable

cockroach-teamcity avatar Aug 28 '24 20:08 cockroach-teamcity

TFTR!

bors r=msbutler

azhu-crl avatar Aug 30 '24 16:08 azhu-crl