cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

changefeed: support primary key columns which are not visible

Open fqazi opened this issue 1 year ago • 1 comments
trafficstars

Previously, when schema changes were happening with an active change feed, it was possible for ALTER PRIMARY KEY USING HASH to have an intermediate state where the hash column could exist within the primary key without being public. This is expected since complex schema changes could not roll back if these columns were made completely public at the same time as the primary key. This would break assumptions within CDC, which expected all primary key columns to be public. To address this, this patch modifies this logic to ignore columns that are writable but not yet fully readable in the primary key.

Fixes: #128457

Release note: None

fqazi avatar Aug 28 '24 19:08 fqazi

This change is Reviewable

cockroach-teamcity avatar Aug 28 '24 19:08 cockroach-teamcity

@asg0451 TFTR!

bors r+

fqazi avatar Oct 08 '24 14:10 fqazi