cockroach
cockroach copied to clipboard
dev: also build `ts_project` for `eslint-plugin-crdb` in `gen js`
Without this, generation can fail with an error like:
Rel: can't make relative to /private/var/tmp/_bazel_davidh/d61affdd093572eb0c41c4220c20a747/execroot/com_github_cockroachdb_cockroach/bazel-out/darwin_arm64-fastbuild/bin/pkg/ui/workspaces/eslint-plugin-crdb/dist
It's unclear right now why this is happening. My suspicion is there is some sort of bug or deficiency in rules_js and/or rules_ts specifically on more recent Bazel versions and is probably related to Bazel 7 being more aggressive about rejecting using directories as output files.
Epic: none
Release note: None Closes: #129369
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?
:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.
It is possible to reproduce after git clean. WDYT doing the same thing in following way?
:ts_project is already a dependency, in deps, of eslint-plugin-crdb-lib. It doesn't really need to be in both srcs and deps.
Does putting it in srcs fix the problem? Should it be in srcs instead of deps?
bors r=koorosh,dhartunian