cockroach
cockroach copied to clipboard
release-23.2: sql: improve handling of contention on non-SQL keys
Backport 1/1 commits from #126346.
/cc @cockroachdb/release
Previously, if we encountered contention on a non-SQL key, it would result in an error being logged every time
crdb_internal.transaction_contention_events is populated. Properly decoding non-SQL keys doesn't seem trivial (plus it wouldn't easily map to columns in the virtual table), so this commit instead adjusts the logic in getContentionEventInfo to do a best-effort decoding, with erroneous cases being handled by including a hint into the tableName string. This should remove concerningly-looking errors from the logs and possibly provide better observability too.
Epic: None Informs: #101826.
Release note: None
Release justification: bug fix.
Thanks for opening a backport.
Please check the backport criteria before merging:
- [ ] Backports should only be created for serious issues or test-only changes.
- [ ] Backports should not break backwards-compatibility.
- [ ] Backports should change as little code as possible.
- [ ] Backports should not change on-disk formats or node communication protocols.
- [ ] Backports should not add new functionality (except as defined here).
- [ ] Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
- [ ] All backports must be reviewed by the owning areas TL and one additional TL. For more information as to how that review should be conducted, please consult the backport policy.
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
- [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
- [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
- [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
- [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
- [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.
Also, please add a brief release justification to the body of your PR to justify this backport.
Friendly ping @dhartunian