cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

crosscluster/logical: support external://

Open dt opened this issue 1 year ago • 6 comments

Release note: none. Epic: none.

dt avatar Jun 29 '24 13:06 dt

This change is Reviewable

cockroach-teamcity avatar Jun 29 '24 13:06 cockroach-teamcity

bors r=stevendanna

stevendanna avatar Jul 01 '24 05:07 stevendanna

Build failed:

craig[bot] avatar Jul 01 '24 05:07 craig[bot]

bors retry

stevendanna avatar Jul 01 '24 06:07 stevendanna

Build failed:

craig[bot] avatar Jul 01 '24 07:07 craig[bot]

Probably just needs a rebase against your other small cleanup PR.

pkg/ccl/crosscluster/logical/logical_replication_job_test.go:155:11: undefined: url

stevendanna avatar Jul 01 '24 07:07 stevendanna

TFTR!

bors r+

dt avatar Jul 01 '24 12:07 dt

Build failed:

craig[bot] avatar Jul 01 '24 12:07 craig[bot]

bors retry

stevendanna avatar Jul 01 '24 13:07 stevendanna

Build failed (retrying...):

craig[bot] avatar Jul 01 '24 14:07 craig[bot]

Build failed:

craig[bot] avatar Jul 01 '24 14:07 craig[bot]

bors r-

msbutler avatar Jul 01 '24 14:07 msbutler

@dt cockroach is not compiling. i think you need to rebase. Craig's errors are misleading. Opened a thread in dev inf about this.

msbutler avatar Jul 01 '24 14:07 msbutler

bors r+

dt avatar Jul 01 '24 15:07 dt