cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

kvclient/rangefeed: add WithEmitMatchingOriginIDs rangefeed client option

Open msbutler opened this issue 1 year ago • 4 comments

This patch adds a rangefeed client level configuration option that configures the rangefeed to emit events originally written by clusters with a matching OriginID during LogicalDataReplication. Currently rangefeeds only support matching to OriginID 0, local writes.

Informs https://github.com/cockroachdb/cockroach/issues/126253

Release note: none

msbutler avatar Jun 28 '24 14:06 msbutler

This change is Reviewable

cockroach-teamcity avatar Jun 28 '24 14:06 cockroach-teamcity

unrelated flake

msbutler avatar Jun 28 '24 15:06 msbutler

What about WithOriginIDsMatching(ids int32...) ?

dt avatar Jun 28 '24 17:06 dt

What about WithOriginIDsMatching(ids int32...) ?

good idea to set this up now. done.

msbutler avatar Jun 28 '24 18:06 msbutler

TFTRs!

bors r=dt,miraradeva,stevendanna

msbutler avatar Jul 01 '24 10:07 msbutler

Build failed:

craig[bot] avatar Jul 01 '24 11:07 craig[bot]

bors retry

msbutler avatar Jul 01 '24 13:07 msbutler

Build failed (retrying...):

craig[bot] avatar Jul 01 '24 14:07 craig[bot]