cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

logical: Add replanning logic to LDR

Open navsetlur opened this issue 1 year ago • 2 comments

Currently there's no replanning logic for logical replication, which means there is no handling for changes to the cluster (e.g. nodes being added or failing). This change uses the PhysicalPlanChecker, which at regular intervals compares the initial plan with a more up to date plan and throws an error whne they differ too much, leading to a replan for the actual logical replication.

Release note: none Part of: https://cockroachlabs.atlassian.net/browse/CRDB-39122

navsetlur avatar Jun 26 '24 19:06 navsetlur

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Jun 26 '24 19:06 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Jun 26 '24 19:06 cockroach-teamcity

Added 2 followups: https://cockroachlabs.atlassian.net/browse/CRDB-39982 https://cockroachlabs.atlassian.net/browse/CRDB-39983

navsetlur avatar Jul 02 '24 17:07 navsetlur

NB: i would not merge this until the test you added passed extended CI (at least under the stress build. ) https://teamcity.cockroachdb.com/viewLog.html?buildId=15929931&buildTypeId=Cockroach_BazelExtendedCi

msbutler avatar Jul 04 '24 12:07 msbutler

NB: i would not merge this until the test you added passed extended CI (at least under the stress build. ) https://teamcity.cockroachdb.com/viewLog.html?buildId=15929931&buildTypeId=Cockroach_BazelExtendedCi

Thanks Michael, will make sure to double check

navsetlur avatar Jul 08 '24 02:07 navsetlur

bors r=stevendanna

navsetlur avatar Jul 08 '24 16:07 navsetlur