cockroach
cockroach copied to clipboard
logical: Add replanning logic to LDR
Currently there's no replanning logic for logical replication, which means there is no handling for changes to the cluster (e.g. nodes being added or failing). This change uses the PhysicalPlanChecker, which at regular intervals compares the initial plan with a more up to date plan and throws an error whne they differ too much, leading to a replan for the actual logical replication.
Release note: none Part of: https://cockroachlabs.atlassian.net/browse/CRDB-39122
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?
:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.
Added 2 followups: https://cockroachlabs.atlassian.net/browse/CRDB-39982 https://cockroachlabs.atlassian.net/browse/CRDB-39983
NB: i would not merge this until the test you added passed extended CI (at least under the stress build. ) https://teamcity.cockroachdb.com/viewLog.html?buildId=15929931&buildTypeId=Cockroach_BazelExtendedCi
NB: i would not merge this until the test you added passed extended CI (at least under the stress build. ) https://teamcity.cockroachdb.com/viewLog.html?buildId=15929931&buildTypeId=Cockroach_BazelExtendedCi
Thanks Michael, will make sure to double check
bors r=stevendanna