cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

oidcccl: HTTP client should respect timeouts

Open pritesh-lahoti opened this issue 1 year ago • 1 comments

Currently, the HTTP client used by the code in the OIDC feature does not respect any timeouts we might have set on our default HTTP client. The go-oidc and oauth2 packages require a custom HTTP client to be set within the context. This change sets an HTTP client with the default timeout (as in pkg/util/httputil) within the context.

Epic: CRDB-38416

Release note: None

pritesh-lahoti avatar Jun 17 '24 06:06 pritesh-lahoti

This change is Reviewable

cockroach-teamcity avatar Jun 17 '24 06:06 cockroach-teamcity

@pritesh-lahoti SGTM

dhartunian avatar Jul 01 '24 14:07 dhartunian

TYFTRs! bors r=dhartunian,souravcrl

pritesh-lahoti avatar Jul 04 '24 05:07 pritesh-lahoti