cockroach
cockroach copied to clipboard
tree,parser: fix round-tripping of StorageParameter
Previously, storage parameters could not round trip the parse-format-parse steps if the parameter key was a reserved keyword.
This was because the Name type was used for keys, which ends up double-quoting the name. For storage parameters, we want single quotes, as they are just string literals, so we can use a normal string type.
fixes https://github.com/cockroachdb/cockroach/issues/124380 Release note: None
tftr!
bors r+
Build succeeded:
Encountered an error creating backports. Some common things that can go wrong:
- The backport branch might have already existed.
- There was a merge conflict.
- The backport branch contained merge commits.
You might need to create your backport manually using the backport tool.
error creating merge commit from cf25884adb9e09803f344dbe2325e6dbef151c63 to blathers/backport-release-23.1-124521: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []
you may need to manually resolve merge conflicts with the backport tool.
Backport to branch 23.1.x failed. See errors above.
:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.