cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

tree,parser: fix round-tripping of StorageParameter

Open rafiss opened this issue 1 year ago • 1 comments
trafficstars

Previously, storage parameters could not round trip the parse-format-parse steps if the parameter key was a reserved keyword.

This was because the Name type was used for keys, which ends up double-quoting the name. For storage parameters, we want single quotes, as they are just string literals, so we can use a normal string type.

fixes https://github.com/cockroachdb/cockroach/issues/124380 Release note: None

rafiss avatar May 21 '24 20:05 rafiss

This change is Reviewable

cockroach-teamcity avatar May 21 '24 20:05 cockroach-teamcity

tftr!

bors r+

rafiss avatar May 28 '24 15:05 rafiss

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from cf25884adb9e09803f344dbe2325e6dbef151c63 to blathers/backport-release-23.1-124521: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 28 '24 15:05 blathers-crl[bot]