cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

backupccl: test that we actually downloaded all data during online restore

Open msbutler opened this issue 1 year ago • 4 comments

Release note: none

Epic: none

msbutler avatar May 15 '24 00:05 msbutler

This change is Reviewable

cockroach-teamcity avatar May 15 '24 00:05 cockroach-teamcity

I think we could slash the size of this change substantially and still get the utility we want to get -- asserting we actually downloaded -- without as much additional test code that we need to maintain/comprehend to read a test, round trips to the DB that make our tests slower to run and can flake, and interactions with system tables.

All we really care about is "are there any external bytes in the cluster?" after the download phase finishes. We could just put that query in a const and then just exec where we need it right?

dt avatar May 15 '24 14:05 dt

given that the query has been simplified so much, it's now a const that any test can use.

msbutler avatar May 15 '24 14:05 msbutler

unrelated test flake

msbutler avatar May 15 '24 18:05 msbutler

TFTR!

bors r+

msbutler avatar May 16 '24 12:05 msbutler

Build failed (retrying...):

craig[bot] avatar May 16 '24 12:05 craig[bot]

Build failed:

craig[bot] avatar May 16 '24 12:05 craig[bot]

bors r=dt

msbutler avatar May 16 '24 20:05 msbutler