cockroach
cockroach copied to clipboard
backupccl: test that we actually downloaded all data during online restore
Release note: none
Epic: none
I think we could slash the size of this change substantially and still get the utility we want to get -- asserting we actually downloaded -- without as much additional test code that we need to maintain/comprehend to read a test, round trips to the DB that make our tests slower to run and can flake, and interactions with system tables.
All we really care about is "are there any external bytes in the cluster?" after the download phase finishes. We could just put that query in a const and then just exec where we need it right?
given that the query has been simplified so much, it's now a const that any test can use.
unrelated test flake
TFTR!
bors r+
bors r=dt