cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

colexecerror: do not catch runtime panics in crdb_test builds

Open michae2 opened this issue 9 months ago • 3 comments

CatchVectorizedRuntimeError performs its stack-walking in order to catch all panics originating from within the vectorized execution engine, including runtime panics. The purpose of this is to limit the impact of a bug in vectorized execution to failure of a single execution rather than crashing the node.

During tests, however, we'd like to make these runtime panics louder, since we believe they represent bugs in vectorized execution. So let's not catch panics under crdb_test builds unless they're wrapped.

Epic: None

Release note: None

michae2 avatar May 14 '24 05:05 michae2

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 14 '24 05:05 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar May 14 '24 05:05 cockroach-teamcity

This came up during a postmortem. I'm not sure yet how much noise it will create in test failures, but curious to hear people's thoughts.

michae2 avatar May 14 '24 17:05 michae2

@mgartner ok if I bors this?

michae2 avatar May 17 '24 17:05 michae2

I'll go ahead, and we can revert this if it breaks something.

bors r=yuzefovich

michae2 avatar May 20 '24 20:05 michae2

Build failed:

craig[bot] avatar May 20 '24 20:05 craig[bot]

bors r=yuzefovich,mgartner

michae2 avatar May 21 '24 19:05 michae2