cockroach
cockroach copied to clipboard
colexecerror: do not catch runtime panics in crdb_test builds
CatchVectorizedRuntimeError performs its stack-walking in order to catch all panics originating from within the vectorized execution engine, including runtime panics. The purpose of this is to limit the impact of a bug in vectorized execution to failure of a single execution rather than crashing the node.
During tests, however, we'd like to make these runtime panics louder, since we believe they represent bugs in vectorized execution. So let's not catch panics under crdb_test builds unless they're wrapped.
Epic: None
Release note: None
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?
:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.
This came up during a postmortem. I'm not sure yet how much noise it will create in test failures, but curious to hear people's thoughts.
@mgartner ok if I bors this?
I'll go ahead, and we can revert this if it breaks something.
bors r=yuzefovich
bors r=yuzefovich,mgartner