cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

changefeedccl: add new table bytes metric for use in billing

Open asg0451 opened this issue 9 months ago • 3 comments

Add a new metric to facilitate the new changefeed billing strategy - changefeed.billing.table_bytes - This is a sum of the bytes watched per changefeed. It intentionally counts tables watched by multiple changefeeds multiple times. Also add auxiliary metrics about billing data collection: changefeed.billing.error_count (counter of errors encountered running the query that generates the table_bytes metric) and changefeed.billing.query_duration (histogram of how long the latter took). The collection of this data and emission of these metrics are gated behind an environment variable only intended to be set in ccloud: COCKROACH_ENABLE_CLOUD_BILLING_ACCOUNTING

Epic: CRDB-37031 Resolves: #121781

Release note (enterprise change): Add a new metric to facilitate the new changefeed billing strategy for usage in Cockroach Cloud.

asg0451 avatar Apr 26 '24 19:04 asg0451

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Apr 26 '24 19:04 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Apr 26 '24 19:04 cockroach-teamcity

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 14 '24 11:05 blathers-crl[bot]

bors r=rharding6373,andyyang890b

asg0451 avatar Jun 07 '24 17:06 asg0451

Timed out.

craig[bot] avatar Jun 07 '24 19:06 craig[bot]

bors r=rharding6373,andyyang890

asg0451 avatar Jun 07 '24 19:06 asg0451

blathers backport 24.1 23.2 23.1

asg0451 avatar Jun 11 '24 19:06 asg0451

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from ea0a1c8912c3d5d519638f72d5d3a9a5cd219640 to blathers/backport-release-23.2-123145: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2 failed. See errors above.


error creating merge commit from ea0a1c8912c3d5d519638f72d5d3a9a5cd219640 to blathers/backport-release-23.1-123145: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1 failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Jun 11 '24 19:06 blathers-crl[bot]