cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

sql: log session variable settings that are set in the connection string

Open lyang24 opened this issue 10 months ago • 3 comments

This commit logs session variables passed on the connection url. The goal is to provide more information on trouble shooting issues. The output could be redacted for security purpose.

Fixes: #122934

Release note: None

lyang24 avatar Apr 24 '24 21:04 lyang24

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

  • @rafiss (author of cockroachdb/cockroach#122934)

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Apr 24 '24 21:04 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Apr 24 '24 21:04 cockroach-teamcity

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Apr 24 '24 23:04 blathers-crl[bot]

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from acf7af8c62464674ed06883951a6f89cf22b0af8 to blathers/backport-release-23.1-123015: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1.x failed. See errors above.


error creating merge commit from acf7af8c62464674ed06883951a6f89cf22b0af8 to blathers/backport-release-23.2-123015: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.2.x failed. See errors above.


error setting reviewers, but backport branch blathers/backport-release-24.1-123015 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/124446/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 24.1.x failed. See errors above.


:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar May 20 '24 21:05 blathers-crl[bot]