cockroach
cockroach copied to clipboard
rowcontainer: switch to using Fingerprint for in-memory hashing
This commit makes it so that we use value encoding for TSQuery and TSVector types in the in-memory hash row container. Previously, we would unconditionally use key encoding and would hit an error in some scenarios (for example in PARTITION BY clauses of window functions that aren't natively supported by the vectorized engine). Since the key encoding support is required for spilling to disk, these queries might still hit an error (but will reference the relevant issue number). Some care had to be taken to handle JSON type separately because it uses value encoding in Fingerprint, but we'll use key encoding if the container spills to disk.
There is no release note given that we haven't seen anyone actually run into this problem (it was caught in the randomized testing).
Fixes: #119567.
Release note: None
Seems like unrelated flake.
bors r+