cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

lint: make runnable under `bazel test`

Open rickystewart opened this issue 1 year ago • 1 comments

This test was never directly runnable under bazel test, and instead required using bazel run with the wrapper target //build/bazelutil:lint that set up some dependencies and some environment variables appropriately. Instead, we simply pass in those environment variables from the CI script or from dev, and add extra dependencies to the lint_test target (crlfmt, optfmt) so the test can use them.

It's necessary to pass GO_SDK as a path to the Bazel-provided Go SDK and COCKROACH_WORKSPACE as the path to the checkout as this stuff will not be found in the sandbox.

Epic: CRDB-8308 Release note: None

rickystewart avatar Feb 23 '24 17:02 rickystewart

This change is Reviewable

cockroach-teamcity avatar Feb 23 '24 17:02 cockroach-teamcity

bors r=rail

rickystewart avatar Mar 06 '24 22:03 rickystewart

Build succeeded:

craig[bot] avatar Mar 06 '24 23:03 craig[bot]