cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

ui: add charts on gc assist metric

Open lyang24 opened this issue 1 year ago • 3 comments

This commit adds a line chart contains gc assist duration on the runtime page. The goal is to present the estimated time user go routines spend on assisting gc tasks.

Informs: https://github.com/cockroachdb/cockroach/pull/118875

Release note: None

gc assist on crdb single node with kv workload gcttl=5s for database in (kv, system) image

lyang24 avatar Feb 22 '24 05:02 lyang24

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I have added a few people who may be able to assist in reviewing:

  • @nvanbenschoten (commented on cockroachdb/cockroach#118875)

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Feb 22 '24 05:02 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Feb 22 '24 05:02 cockroach-teamcity

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

:owl: Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

blathers-crl[bot] avatar Feb 22 '24 06:02 blathers-crl[bot]

bors r+

lyang24 avatar Mar 04 '24 20:03 lyang24

Build succeeded:

craig[bot] avatar Mar 04 '24 21:03 craig[bot]