cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

ccl/changefeedccl: unskip TestChangefeedOnlyInitialScanCSV for pulsar sink

Open cockroach-teamcity opened this issue 1 year ago • 5 comments

ccl/changefeedccl.TestChangefeedOnlyInitialScanCSV failed on master @ 617bf347978dcc0d711399b1a76402d7f88de958:

=== RUN   TestChangefeedOnlyInitialScanCSV
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestChangefeedOnlyInitialScanCSV2394812205
    test_log_scope.go:81: use -show-logs to present logs inline
    changefeed_test.go:7530: -- test log scope end --
test logs left over in: outputs.zip/logTestChangefeedOnlyInitialScanCSV2394812205
--- FAIL: TestChangefeedOnlyInitialScanCSV (1.54s)
=== RUN   TestChangefeedOnlyInitialScanCSV/pulsar
    helpers_test.go:867: making server as system tenant
    helpers_test.go:943: making pulsar feed factory
    --- FAIL: TestChangefeedOnlyInitialScanCSV/pulsar (1.53s)
=== RUN   TestChangefeedOnlyInitialScanCSV/pulsar/initial_scan_only_with_csv
    changefeed_test.go:7513: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7513
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7525
        	Error:      	Not equal: 
        	            	expected: 3
        	            	actual  : 2
        	Test:       	TestChangefeedOnlyInitialScanCSV/pulsar/initial_scan_only_with_csv
        --- FAIL: TestChangefeedOnlyInitialScanCSV/pulsar/initial_scan_only_with_csv (0.32s)

Parameters:

  • attempt=1
  • run=7
  • shard=14
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/cdc

This test on roachdash | Improve this report!

Jira issue: CRDB-36130

cockroach-teamcity avatar Feb 16 '24 07:02 cockroach-teamcity

ccl/changefeedccl.TestChangefeedOnlyInitialScanCSV failed on master @ c9c3cc5f3c3a4a6ab556f4b9d5b6ec0381901bdb:

=== RUN   TestChangefeedOnlyInitialScanCSV
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestChangefeedOnlyInitialScanCSV809831575
    test_log_scope.go:81: use -show-logs to present logs inline
    changefeed_test.go:7530: -- test log scope end --
test logs left over in: outputs.zip/logTestChangefeedOnlyInitialScanCSV809831575
--- FAIL: TestChangefeedOnlyInitialScanCSV (1.53s)
=== RUN   TestChangefeedOnlyInitialScanCSV/pulsar
    helpers_test.go:867: making server as system tenant
    helpers_test.go:943: making pulsar feed factory
    --- FAIL: TestChangefeedOnlyInitialScanCSV/pulsar (1.52s)
=== RUN   TestChangefeedOnlyInitialScanCSV/pulsar/initial_backfill_only_with_csv_multiple_tables
    changefeed_test.go:7513: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7513
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7525
        	Error:      	Not equal: 
        	            	expected: 6
        	            	actual  : 5
        	Test:       	TestChangefeedOnlyInitialScanCSV/pulsar/initial_backfill_only_with_csv_multiple_tables
        --- FAIL: TestChangefeedOnlyInitialScanCSV/pulsar/initial_backfill_only_with_csv_multiple_tables (0.30s)

Parameters:

  • attempt=1
  • run=2
  • shard=14
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

cockroach-teamcity avatar Feb 26 '24 07:02 cockroach-teamcity

ccl/changefeedccl.TestChangefeedOnlyInitialScanCSV failed on master @ 7bb52a7d1c75d5adfdfa53e5fcff6f5e6497408f:

=== RUN   TestChangefeedOnlyInitialScanCSV
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestChangefeedOnlyInitialScanCSV311463542
    test_log_scope.go:81: use -show-logs to present logs inline
    changefeed_test.go:7530: -- test log scope end --
test logs left over in: outputs.zip/logTestChangefeedOnlyInitialScanCSV311463542
--- FAIL: TestChangefeedOnlyInitialScanCSV (1.63s)
=== RUN   TestChangefeedOnlyInitialScanCSV/pulsar
    helpers_test.go:867: making server as system tenant
    helpers_test.go:943: making pulsar feed factory
    --- FAIL: TestChangefeedOnlyInitialScanCSV/pulsar (1.62s)
=== RUN   TestChangefeedOnlyInitialScanCSV/pulsar/initial_backfill_only_with_csv
    changefeed_test.go:7513: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7513
        	            				github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_test.go:7525
        	Error:      	Not equal: 
        	            	expected: 3
        	            	actual  : 2
        	Test:       	TestChangefeedOnlyInitialScanCSV/pulsar/initial_backfill_only_with_csv
        --- FAIL: TestChangefeedOnlyInitialScanCSV/pulsar/initial_backfill_only_with_csv (0.28s)

Parameters:

  • attempt=1
  • run=18
  • shard=14
Help

See also: How To Investigate a Go Test Failure (internal)

This test on roachdash | Improve this report!

cockroach-teamcity avatar Feb 27 '24 07:02 cockroach-teamcity

Will skip this test

jayshrivastava avatar Feb 27 '24 18:02 jayshrivastava

We should fix and unskip this test before making pulsar available for beta.

rharding6373 avatar Mar 20 '24 00:03 rharding6373

Re-opening since this test is skipped again.

rharding6373 avatar May 23 '24 20:05 rharding6373

This test is blocked by https://github.com/cockroachdb/cockroach/issues/118899. The test fails because the current mock pulsar implementation is not quite fully synchronous but not fully asynchronous, either. Namely, the changefeed data is emitted into a buffered channel, and then acked. Since this test is for an initial scan, this means that the changefeed can close before the test fully consumes the data to check for success.

Downgrading to a P3, since we won't be able to get to this right now.

rharding6373 avatar Jun 04 '24 14:06 rharding6373