cockroach icon indicating copy to clipboard operation
cockroach copied to clipboard

release-23.2: sql: add telemetry block regexps and fix flake

Open mgartner opened this issue 1 year ago • 3 comments

Backport 2/2 commits from #117558.

/cc @cockroachdb/release


sqltestutils: allow blocking regexps in telemetry feature list

The feature-allowlist directive for telemetry tests has been renamed feature-list and it now supports blocking regexps. Any line in the feature-list that starts with "!" is a block regexp that prevents any features matching the regexp from being included in the output of the feature-usage and feature-counters directives. This is helpful because Go's regexps do not support negative look-aheads, so adding features that should not be matched is difficult and tedious.

Release note: None

sql: ignore "sql.schema.create_stats" in schema telemetry test

This commit ignores the sql.schema.create_stats in the schema telemetry tests because it causes sporadic failures.

Fixes #117309

Release note: None


Release justification: Test-only fixes for flaky tests.

mgartner avatar Feb 12 '24 16:02 mgartner

Thanks for opening a backport.

Please check the backport criteria before merging:

  • [ ] Backports should only be created for serious issues or test-only changes.
  • [ ] Backports should not break backwards-compatibility.
  • [ ] Backports should change as little code as possible.
  • [ ] Backports should not change on-disk formats or node communication protocols.
  • [ ] Backports should not add new functionality (except as defined here).
  • [ ] Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • [ ] All backports must be reviewed by the owning areas TL and one additional TL. For more information as to how that review should be conducted, please consult the backport policy.
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • [ ] There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • [ ] The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • [ ] New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • [ ] The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • [ ] Your backport must be accompanied by a post to the appropriate Slack channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this backport.

blathers-crl[bot] avatar Feb 12 '24 16:02 blathers-crl[bot]

This change is Reviewable

cockroach-teamcity avatar Feb 12 '24 16:02 cockroach-teamcity

Friendly ping :)

mgartner avatar Feb 21 '24 20:02 mgartner