cockroach-operator icon indicating copy to clipboard operation
cockroach-operator copied to clipboard

Sanity check if the image name has a colon

Open hoyhbx opened this issue 3 years ago • 2 comments

fix https://github.com/cockroachdb/cockroach-operator/issues/918

We fixed the issue by adding sanity check to examine whether a colon is contained in the image name in IsLoggingAPIEnabled function. If there is no colon in image name, we will not retrieve index 1 and will directly return false.

Checklist

  • [ ] I have added these changes to the changelog (or it's not applicable).

hoyhbx avatar Jun 22 '22 21:06 hoyhbx

Thanks for your response. We have added a unit test in our latest commit.

hoyhbx avatar Jul 15 '22 21:07 hoyhbx

@pseudomuto Could you review this so that it can be merged? I think this is a pretty straight-forward fix

hoyhbx avatar Apr 02 '23 02:04 hoyhbx