cockroach-go icon indicating copy to clipboard operation
cockroach-go copied to clipboard

Vendor GetTotalMemoryWithoutLogging from github.com/cockroachdb/cockroach

Open com6056 opened this issue 2 years ago • 4 comments

Is there any chance we can get https://github.com/cockroachdb/cockroach/blob/7fe21a3b907aa148fcccc8ba62b9ac4db1ada50f/pkg/server/status/recorder.go#L644-L683 (and all child functions) vendored into this repo? Right now we have to copy over the code because importing github.com/cockroachdb/cockroach into our project isn't feasible. It would be great to have the same code that detects the memory usage available in this library since the testserver uses that value.

com6056 avatar Mar 14 '23 00:03 com6056

It seems like the real ask here is for us to make the cgroups library go-gettable as its own module, yeah?

ajwerner avatar Mar 14 '23 01:03 ajwerner

Sure, that works too!

com6056 avatar Mar 14 '23 01:03 com6056

Any updates on this? Thanks!

com6056 avatar Dec 16 '23 01:12 com6056

Friendly bump on this, thanks!

com6056 avatar Apr 11 '24 21:04 com6056