[ActiveRecord 5.2 Test Failure] test/cases/adapters/postgresql/type_lookup_test.rb

[alimi]

Failure:
PostgresqlTypeLookupTest#test_range_types_correctly_respect_registration_of_subtypes [/Users/alimi/repos/rails/activerecord/test/cases/adapters/postgresql/type_lookup_test.rb:32]:
ActiveModel::RangeError expected but nothing was raised.

bin/rails test Users/alimi/repos/rails/activerecord/test/cases/adapters/postgresql/type_lookup_test.rb:27

Error:
PostgresqlTypeLookupTest#test_array_delimiters_are_looked_up_correctly:
NoMethodError: undefined method `delimiter' for #<ActiveModel::Type::Value:0x00007ff62a360d58>
Did you mean?  limit
    /Users/alimi/repos/rails/activerecord/test/cases/adapters/postgresql/type_lookup_test.rb:14:in `block in <class:PostgresqlTypeLookupTest>'

bin/rails test Users/alimi/repos/rails/activerecord/test/cases/adapters/postgresql/type_lookup_test.rb:10

See the Contributing Guide for instructions on running tests.

If the test isn't valid against CockroachDB

1. Add a ruby file to test/excludes that matches the name of the test class if one doesn't already exist. For example to exclude a test from ActiveRecord::AdapterTest, create test/excludes/ActiveRecord/AdapterTest.rb.
2. Add an exclude statement to the file with the name of the test to exclude and a description. For example to exclude test_indexes from ActiveRecord::AdapterTest: https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/c3cb637bd855b36bbf9e76b7947162054b95022e/test/excludes/ActiveRecord/AdapterTest.rb#L1
3. Finally, if the test can run against CockroachDB with a few changes, add it to test/cases. Everything from the ActiveRecord test suite will be available, so a lot of the excluded test can be copied over. Namespace the test under the CockroachDB module to avoid name collisions. See test/cases/adapter_test.rb for an example.

See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48.