activerecord-cockroachdb-adapter icon indicating copy to clipboard operation
activerecord-cockroachdb-adapter copied to clipboard

add Jets support

Open flippakitten opened this issue 5 years ago • 3 comments

flippakitten avatar Jul 18 '19 12:07 flippakitten

What is Jets?

jordanlewis avatar Jul 18 '19 14:07 jordanlewis

@jordanlewis

What is Jets?

Ruby on Jets. https://rubyonjets.com/ Basically it's Rails but runs in AWS Lambda's

I was contemplating a completely separate gem but as Jets uses active-record, it seems like a better option to include it in here.

flippakitten avatar Jul 18 '19 14:07 flippakitten

@flippakitten are you still up to being champion for this PR?

If yes, I have a few questions.

Is it still worth it, as there are rails support options in jets?

I feel like this is not ok: we are basically loading the tasks every time. But in rails it is only done on task loading. There is a Railtie hook. I found a #rake_tasks method in jets, but not sure it works the same way.

Looking on sourcegraph, I think a railtie equivalent in jets is a turbine.

Anyway, there is a bit more investigation/work to do for this integration. Are you up to the task?

Otherwise I'd be in favor of closing as the output of sourcegraph has shown very few repos supporting jets, I don't think we should invest that much time in it!

also trains are better than jets <3

BuonOmo avatar Jul 03 '23 16:07 BuonOmo