activerecord-cockroachdb-adapter icon indicating copy to clipboard operation
activerecord-cockroachdb-adapter copied to clipboard
verified publisher icon cockroachdb

DRAFT: feat: support datetime precision

Open BuonOmo opened this issue 2 years ago • 1 comments

This fixes some failing tests AND add a new feature :)

The only thing that worries me is that default of precision 6, which makes some of the compatibility test nonsensical.

I've talked about it in https://github.com/cockroachdb/cockroach/issues/110787#issuecomment-1737754509

BuonOmo avatar Sep 27 '23 18:09 BuonOmo

I cannot officially mark it as draft again, but I have sever doubt about this PR: the default precision with pg is 0, and crdb 6. I don't know what that implies on every levels yet. And seeing the huge amount of failures, I don't think I'll have time to dig further soon.

BuonOmo avatar Sep 30 '23 20:09 BuonOmo

Fixed by https://github.com/cockroachdb/activerecord-cockroachdb-adapter/commit/0c2678d79f2bcc66fc02d08ea4a847c63416a362

BuonOmo avatar Jul 10 '24 13:07 BuonOmo