[ActiveRecord 5.2 Test Failure] test/cases/migration/references_statements_test.rb

[alimi]

Error:
ActiveRecord::Migration::ReferencesStatementsTest#test_deletes_reference_type_column:
ActiveRecord::StatementInvalid: PG::InvalidColumnReference: ERROR:  column "supplier_id" is referenced by existing index "index_test_models_on_supplier_id_and_supplier_type"
: ALTER TABLE "test_models" DROP COLUMN "supplier_id"
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:75:in `exec'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:75:in `block (2 levels) in execute'
    /Users/alimi/repos/rails/activesupport/lib/active_support/dependencies/interlock.rb:48:in `block in permit_concurrent_loads'
    /Users/alimi/repos/rails/activesupport/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'
    /Users/alimi/repos/rails/activesupport/lib/active_support/dependencies/interlock.rb:47:in `permit_concurrent_loads'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:74:in `block in execute'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:581:in `block (2 levels) in log'
    /Users/alimi/.rvm/rubies/ruby-2.5.3/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:580:in `block in log'
    /Users/alimi/repos/rails/activesupport/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:571:in `log'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:73:in `execute'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:603:in `remove_column'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:905:in `remove_reference'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/helper.rb:38:in `remove_reference'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:106:in `block in test_deletes_reference_type_column'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:134:in `with_polymorphic_column'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:105:in `test_deletes_reference_type_column'

bin/rails test Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:104

Error:
ActiveRecord::Migration::ReferencesStatementsTest#test_deletes_polymorphic_index:
ActiveRecord::StatementInvalid: PG::InvalidColumnReference: ERROR:  column "supplier_id" is referenced by existing index "index_test_models_on_supplier_id_and_supplier_type"
: ALTER TABLE "test_models" DROP COLUMN "supplier_id"
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:75:in `exec'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:75:in `block (2 levels) in execute'
    /Users/alimi/repos/rails/activesupport/lib/active_support/dependencies/interlock.rb:48:in `block in permit_concurrent_loads'
    /Users/alimi/repos/rails/activesupport/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'
    /Users/alimi/repos/rails/activesupport/lib/active_support/dependencies/interlock.rb:47:in `permit_concurrent_loads'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:74:in `block in execute'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:581:in `block (2 levels) in log'
    /Users/alimi/.rvm/rubies/ruby-2.5.3/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:580:in `block in log'
    /Users/alimi/repos/rails/activesupport/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:571:in `log'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:73:in `execute'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:603:in `remove_column'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:905:in `remove_reference'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/helper.rb:38:in `remove_reference'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:113:in `block in test_deletes_polymorphic_index'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:134:in `with_polymorphic_column'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:112:in `test_deletes_polymorphic_index'

bin/rails test Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:111

Error:
ActiveRecord::Migration::ReferencesStatementsTest#test_does_not_delete_reference_type_column:
ActiveRecord::StatementInvalid: PG::InvalidColumnReference: ERROR:  column "supplier_id" is referenced by existing index "index_test_models_on_supplier_id_and_supplier_type"
: ALTER TABLE "test_models" DROP COLUMN "supplier_id"
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:75:in `exec'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:75:in `block (2 levels) in execute'
    /Users/alimi/repos/rails/activesupport/lib/active_support/dependencies/interlock.rb:48:in `block in permit_concurrent_loads'
    /Users/alimi/repos/rails/activesupport/lib/active_support/concurrency/share_lock.rb:187:in `yield_shares'
    /Users/alimi/repos/rails/activesupport/lib/active_support/dependencies/interlock.rb:47:in `permit_concurrent_loads'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:74:in `block in execute'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:581:in `block (2 levels) in log'
    /Users/alimi/.rvm/rubies/ruby-2.5.3/lib/ruby/2.5.0/monitor.rb:226:in `mon_synchronize'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:580:in `block in log'
    /Users/alimi/repos/rails/activesupport/lib/active_support/notifications/instrumenter.rb:23:in `instrument'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract_adapter.rb:571:in `log'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/postgresql/database_statements.rb:73:in `execute'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:603:in `remove_column'
    /Users/alimi/repos/rails/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb:905:in `remove_reference'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/helper.rb:38:in `remove_reference'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:97:in `block in test_does_not_delete_reference_type_column'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:134:in `with_polymorphic_column'
    /Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:96:in `test_does_not_delete_reference_type_column'

bin/rails test Users/alimi/repos/rails/activerecord/test/cases/migration/references_statements_test.rb:95

See the Contributing Guide for instructions on running tests.

If the test isn't valid against CockroachDB

1. Add a ruby file to test/excludes that matches the name of the test class if one doesn't already exist. For example to exclude a test from ActiveRecord::AdapterTest, create test/excludes/ActiveRecord/AdapterTest.rb.
2. Add an exclude statement to the file with the name of the test to exclude and a description. For example to exclude test_indexes from ActiveRecord::AdapterTest: https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/c3cb637bd855b36bbf9e76b7947162054b95022e/test/excludes/ActiveRecord/AdapterTest.rb#L1
3. Finally, if the test can run against CockroachDB with a few changes, add it to test/cases. Everything from the ActiveRecord test suite will be available, so a lot of the excluded test can be copied over. Namespace the test under the CockroachDB module to avoid name collisions. See test/cases/adapter_test.rb for an example.

See https://github.com/cockroachdb/activerecord-cockroachdb-adapter/issues/48.