cockpit icon indicating copy to clipboard operation
cockpit copied to clipboard

build: Drop --enable-old-bridge configure option

Open martinpitt opened this issue 2 years ago • 1 comments

This isn't supported on the main branch any more since we dropped supprot for RHEL 8. This was already cleaned up in the spec file and tests. HACK_SPEC_FOR_PYTHON is also not a thing any more.

Also clean up the four ws tests which we haven't run any more since then.

Much of src/bridge can also go now, but we'll leave that for #20000. As automake requires a defined conditional for if, define an always-false WITH_OLD_BRIDGE for now.


NB: This is not the big cleanup from #20000 yet. I added that conditional hack specifically to avoid that :grin: A lot of that can happen now, but @allisonkarlitskaya reserved that fun for her. I mostly just want to get rid of the OLD_BRIDGE configure stuff as I keep running into it while working on #19441

martinpitt avatar Mar 22 '24 06:03 martinpitt

@allisonkarlitskaya: This doesn't block me after all, so I'll leave it up to you what you want to do with this -- land, reject, or expand into #20000.

martinpitt avatar Mar 22 '24 06:03 martinpitt

@jelly yes, it is -- this does not drop cockpit-pcp, nor does it drop the cockpit-bridge code. See the details in the PR description. This only drops the --enable-old-bridge config option, which we really should have done months ago.

martinpitt avatar Jun 17 '24 10:06 martinpitt

@jelly yes, it is -- this does not drop cockpit-pcp, nor does it drop the cockpit-bridge code. See the details in the PR description. This only drops the --enable-old-bridge config option, which we really should have done months ago.

Right, but can I still then build cockpit-pcp easily after this?

jelly avatar Jun 17 '24 11:06 jelly

@jelly yes, both cockpit-pcp and cockpit-ssh are still built from C sources today, they don't count as "old". This only applies to cockpit-bridge itself.

martinpitt avatar Jun 17 '24 11:06 martinpitt