cockpit icon indicating copy to clipboard operation
cockpit copied to clipboard

ssh: Replace cockpit-ssh with cockpit.beiboot

Open martinpitt opened this issue 2 years ago • 0 comments

cockpit.beiboot has feature parity with cockpit-ssh. Entirely stop building and shipping cockpit-ssh with the pybridge, and use cockpit.beiboot by default for direct remote SSH logins from the login page. This gets rid of the libssh build dependency.

Drop the Provides: cockpit-ssh from Debian. No package ever related to that virtual package name, and it's meaningless these days.

Change ws' detection of remote login availability to type cockpit-bridge with the pybridge, as the existence of cockpit-ssh is not relevant any more. This is much cheaper than actually trying to run the bridge with --version or call Python to check the module. We still need to do this, as a system could only have the cockpit-ws package installed but not cockpit-bridge.

https://issues.redhat.com/browse/COCKPIT-1029

TODO:

  • [x] PR #19435
  • [ ] PR #19401
  • [x] Convert unknown host key prompts to proper authorize message/UI (see FIXME in testLoginSshBeiboot), breaks several integration tests
  • [ ] Drop src/ssh/
  • [ ] docs, selinux policy, comments, etc. -- git grep cockpit-ssh
  • [ ] Drop testLoginSshBeiboot, ensure all failure scenarios are included in other tests
  • [ ] Figure out a new mechanism to disable beiboot functionality from distro packages (until we devise a new policy), and add a test for that

martinpitt avatar Oct 05 '23 06:10 martinpitt