cockpit-machines icon indicating copy to clipboard operation
cockpit-machines copied to clipboard

fix: Missing spacing between input and form helper text solves #1164

Open ashutosh7i opened this issue 1 year ago • 2 comments

Hello @jelly & @KKoukiou , i have worked on this issue,

Image with issue-

Screenshot from 2023-12-17 01-55-22

After my Solution to the issue- image

The fix i implemented is that i replaced

<FormHelper ... /> component

with the official component-

<HelperText>
                    <HelperTextItem variant="error">{ ... } </HelperTextItem>
</HelperText>

image

And tweaked css in Machines.scss

image

this workaround fixed the issue of missing spacing between input and helper text solving #1164

ashutosh7i avatar Dec 16 '23 21:12 ashutosh7i

For reference:

Here's a screenshot of JSX React on PatternFly's demo page @ https://www.patternfly.org/components/helper-text/react-demos

image

garrett avatar Jan 16 '24 09:01 garrett

sure @garrett i am onto it.

ashutosh7i avatar Feb 01 '24 18:02 ashutosh7i