bots icon indicating copy to clipboard operation
bots copied to clipboard

WIP: c1bf2e3c876c: [no-test] images: rhel4edge - remove workaround and use osbuild.ks as main config file

Open jscotka opened this issue 9 months ago • 24 comments

Image refresh for rhel4edge

  • [ ] image-refresh rhel4edge

Fixes #6356

jscotka avatar May 09 '24 13:05 jscotka

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-e35db370-20240509-133354/log.html

cockpituous avatar May 09 '24 14:05 cockpituous

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-5b943cc0-20240510-111050/log.html

cockpituous avatar May 10 '24 12:05 cockpituous

image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240510-131557

cockpituous avatar May 10 '24 13:05 cockpituous

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-5b943cc0-20240510-122138/log.html

cockpituous avatar May 10 '24 13:05 cockpituous

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-c8cb126e-20240513-110217/log.html

cockpituous avatar May 13 '24 11:05 cockpituous

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-0f66a93b-20240513-123332/log.html

cockpituous avatar May 13 '24 13:05 cockpituous

image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240514-084435

cockpituous avatar May 14 '24 08:05 cockpituous

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-b2745df5-20240514-074957/log.html

cockpituous avatar May 14 '24 08:05 cockpituous

Triggered the tests.

jelly avatar May 14 '24 08:05 jelly

image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240515-080225

cockpituous avatar May 15 '24 08:05 cockpituous

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-ebd04d1b-20240515-071355/log.html

cockpituous avatar May 15 '24 08:05 cockpituous

the issue inside rhel4edge/other@cockpit-project/cockpit may be caused by different defaults for home directories folder from my PoV, not sure if really, just guessing now. But question is if we should fix the test, or try to add another workaround for this into image regeneration.

jscotka avatar May 15 '24 09:05 jscotka

Thanks @jscotka for the examination in https://github.com/cockpit-project/cockpit/issues/20479 ! IMHO this is a bug in creating the admin user -- /etc/default/useradd's HOME=/var/home is at odds with /home/admin being the home dir -- it is /var/home/admin everywhere else on OSTree. So my suggestion would be to fix /etc/passwd after the fact in the setup script.

martinpitt avatar May 22 '24 15:05 martinpitt

Thanks @jscotka for the examination in cockpit-project/cockpit#20479 ! IMHO this is a bug in creating the admin user -- /etc/default/useradd's HOME=/var/home is at odds with /home/admin being the home dir -- it is /var/home/admin everywhere else on OSTree. So my suggestion would be to fix /etc/passwd after the fact in the setup script.

Sure @martinpitt not sure if it is a bug, or just little bit different workflow how the users are created. But you are right it could be issue inside anaconda, that it does not respect this setting of HOME or some missing param to anaconda in case this HOME var for adduser command is added to system later.

My feeling here is, that as SSH behaves correctly, as it does not resolve symlink, so when SSH to machine, the ~ is displayed, and it is switched to /home/admin, not resolved symlink dir, although Terminal plugin what cockpit uses probably just make additional resolving of directory, what is probably not good option.

Whoever use symlinks for users, will end up with this issues, that ~ is not displayed as the first command prompt. So from that perspective it is not issue of rhel4edge, but common issue when using symlinks for user home dirs.

My idea is to fix it as you wish with improve home dir for admin user and let opened the issue, to force somehow the Terminal cockpit plugin to behave more correctly and do not resolve the dir.

jscotka avatar May 22 '24 20:05 jscotka

That's not specific to SSH. It's just fallout from OSTree's choice of putting home dirs into /var/home/, and happens with any login where an user has their home dir set (in /etc/passwd) to /home/user.

martinpitt avatar May 23 '24 05:05 martinpitt

Previous run timed out, trying again.

martinpitt avatar May 23 '24 05:05 martinpitt

@jscotka Timed out two times in a row -- is there a way to get some logs of the image build process? It apparently still reported "BUILDING" not fail/error or so. But maybe it's hanging somewhere?

martinpitt avatar May 23 '24 07:05 martinpitt

That's not specific to SSH. It's just fallout from OSTree's choice of putting home dirs into /var/home/, and happens with any login where an user has their home dir set (in /etc/passwd) to /home/user.

I understand it. I wanted to say, that SSH behaves correctly from that perspective, what is initial dir, no matter where are home dirs stored and how are symlinked. I understand that there is now difference between OSTree choice and rhel4edge, or better to say, from my perspective just cosmetic, as probably also inside OSTree there will be this symlink /home -> var/home, so that user dirs are stored on same places everywhere, just changed if there is used full less-standard path or symlinked more common path for home dirs.

jscotka avatar May 23 '24 07:05 jscotka

@jscotka Timed out two times in a row -- is there a way to get some logs of the image build process? It apparently still reported "BUILDING" not fail/error or so. But maybe it's hanging somewhere?

Theoretically yes, I think that possible via logging into console.rh.com with bots credentials. and look into status of building process or with bots token and getting logs via cmd line. Maybe it was just stucked and took longer time than 120m, it is my feeling, but unable to look into it.

jscotka avatar May 23 '24 08:05 jscotka

I've created the issue into edge project: https://issues.redhat.com/browse/THEEDGE-3955

jscotka avatar May 23 '24 09:05 jscotka

@martinpitt seems currently there is some outage, Now trying it locally, and build still in progress for long time, than it is typical: https://console.redhat.com/edge/manage-images/3433 so I'll see later. My feel is just some glitch inside infra. We'll see later.

jscotka avatar May 23 '24 10:05 jscotka

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-af5b9839-20240524-040806/log.html

cockpituous avatar May 24 '24 04:05 cockpituous

@jscotka aha, a "proper" failure, that may at least be more useful for debugging? I still don't see the logs yet, though :(

martinpitt avatar May 24 '24 04:05 martinpitt

@jscotka aha, a "proper" failure, that may at least be more useful for debugging? I still don't see the logs yet, though :(

Hi Martin, there is no proper failure as I though as well. I've looked into web UI and there is nothing more useful, no log, just error state for the image

jscotka avatar May 24 '24 05:05 jscotka

edge image building should be already fixed, trying to reschedule it.

jscotka avatar May 28 '24 06:05 jscotka

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-af5b9839-20240528-154438/log.html

cockpituous avatar May 28 '24 16:05 cockpituous

Failed. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-af5b9839-20240528-172721/log.html

cockpituous avatar May 28 '24 18:05 cockpituous

image-refresh rhel4edge done: https://github.com/cockpit-project/bots/commits/image-refresh-rhel4edge-20240528-201338

cockpituous avatar May 28 '24 20:05 cockpituous

Success. Log: https://cockpit-logs.us-east-1.linodeobjects.com/image-refresh-rhel4edge-5e5c7183-20240528-191601/log.html

cockpituous avatar May 28 '24 20:05 cockpituous

Nice, thanks! I pushed the image and triggered tests.

martinpitt avatar May 29 '24 05:05 martinpitt