coc-powershell icon indicating copy to clipboard operation
coc-powershell copied to clipboard

Integrated PS console - follow up

Open mikeTWC1984 opened this issue 5 years ago • 20 comments

Did some clean up/overview and realize some old issues are still there

  1. Despite #52 powershell.execute command still doesn't work properly, file path is generated but is sent to a new terminal (not the integrated one) and closes immediately. Tested in both vim/nvim (latest) on a fresh Ubuntu container.

  2. evaluateSelection doesn't work in Vim (works fine in NeoVim). Getting this error: request error nvim_buf_get_mark buf_get_mark support current buffer only

  3. Integrated console doesn't work in Windows. gVim throws some error, but neovim just not loading it (using latest versions of both). I guess vim is not the best option for powershell stuff on windows anyway, so this is more like FYI, in case anybody is willing to research that.

mikeTWC1984 avatar Jul 24 '19 03:07 mikeTWC1984

@yatli have we done a release since #52 went in?

TylerLeonhardt avatar Jul 26 '19 03:07 TylerLeonhardt

Number 2 is probably related to our selection implementation... It's a bit of a hack.

@chemzqm anything that you might need that could help with understanding the 3rd problem? Seems like that's possibly a coc.nvim issue?

TylerLeonhardt avatar Jul 26 '19 03:07 TylerLeonhardt

I'm using NVIM v0.4.0-1234-g1b99aa8c5 and not having any issues with PSIC in nvim, or nvim-qt (biggest trouble is remembering how to exit the terminal...) I also don't recall having any issues with nvim stable, but it's been a while so I could be wrong...

corbob avatar Jul 26 '19 04:07 corbob

@corbob Is that on Windows? I think on Windows problems starts when you install coc extensions, getting error from npm about certificates or something (although npm works fine outside vim, and I can run build.ps1 just fine). Idk, maybe manual install will help Just realized windows terminal is already on choco, looking forward to try vim on it.

@TylerLeonhardt , @yatli I discovered that integrated terminal acts a bit quircky in neovim. Usually when I'm get there it's not in insert mode. And some times when you get in insert mode cursor get somewhere in the middle, so need to type cls to escape that mess. In VIM it works just fine (it always in insert mode). Besides that neovim looks like much better choice for ps.

mikeTWC1984 avatar Jul 26 '19 16:07 mikeTWC1984

I see 1 and 2 are fix for both vim/neovim, thanks! I'm good to close this

mikeTWC1984 avatar Jul 31 '19 19:07 mikeTWC1984

@mikeTWC1984 is 3 still an issue?

TylerLeonhardt avatar Aug 01 '19 00:08 TylerLeonhardt

@mikeTWC1984 which version of gVim are you running? At least 8.0 is required

yatli avatar Aug 01 '19 08:08 yatli

Yes, still getting same error. Using 8.1 (latest available on their website) gvim81err I'm getting it on 3 different machines so I assume this is something common.

mikeTWC1984 avatar Aug 01 '19 17:08 mikeTWC1984

can you provide the output of :CocInfo?

:CocOpenLog may also help

yatli avatar Aug 01 '19 17:08 yatli

cocinfo

mikeTWC1984 avatar Aug 01 '19 17:08 mikeTWC1984

this is lcocopenlog: 2019-08-01T13:17:32.972 INFO (pid:34232) [plugin] - coc 0.0.73-d9ac1b1568 initialized with node: v10.16.0

mikeTWC1984 avatar Aug 01 '19 17:08 mikeTWC1984

Are you guys able to launch it on windows with no problem?

mikeTWC1984 avatar Aug 01 '19 17:08 mikeTWC1984

I'm always sticking to Windows, no problem on my side. I use NeoVim.

yatli avatar Aug 01 '19 17:08 yatli

This doesn't look like a Vim-related problem -- more likely on the javascript side. Which version of Windows are you running?

yatli avatar Aug 01 '19 17:08 yatli

windows 10 and server 2016. Do you have any issue with gVim on your end? I have neovim 0.38 on one of the machines, but terminal just doesn't start.

mikeTWC1984 avatar Aug 01 '19 20:08 mikeTWC1984

I realized I didn't have polyglot on my nvim. After adding completion started working. Tested this on 2 machines. I guess we need to update read me to move polyglot from recommended to prereq. Still can't get it to work with gvim. But I'm good for now anyway

mikeTWC1984 avatar Aug 02 '19 01:08 mikeTWC1984

Sounds good. Is it cool that we close this? I think you should open an issue on gvim or coc for better support there but also we should have an issue opened to have polyglot not be a dependency

TylerLeonhardt avatar Aug 02 '19 03:08 TylerLeonhardt

@mikeTWC1984 I have the problem repro. [coc.nvim] Error on active extension coc-powershell: TypeError: (intermediate value) is not iterable Environment is: Windows 10 1903 node 10.11 coc 0.0.73 polyglot: yes

I will trace this problem now.

yatli avatar Aug 02 '19 03:08 yatli

Yeah, since nvim is working fine, we definitely can close it. If you guys can figure out if it's coc.nvim or gvim issue I can forward this to them

mikeTWC1984 avatar Aug 02 '19 13:08 mikeTWC1984

I have the same problem, trying to use coc-powershell on windows. Enabled the debug log and found this:

2019-09-25T15:31:17.924 ERROR (pid:23096) [extensions] - TypeError: (intermediate value) is not iterable
    at TerminalModel.start (C:\Users\ankarloog\Dropbox\Utilities\gVimPortable8\Data\settings\vimfiles\bundle\coc.nvim\build\index.js:30387:28)
    at process._tickCallback (internal/process/next_tick.js:68:7)

My Environment is:

vim version: VIM - Vi IMproved 8.1 (2018 May 18, compiled May 18 2018 18:36:07)
node version: v10.16.3
coc.nvim version: 0.0.74-07b00fd6fc
term: undefined
platform: win32
polygot: yes

Gankarloo avatar Sep 25 '19 13:09 Gankarloo