ghost-on-heroku
ghost-on-heroku copied to clipboard
cobyism
Ghost 3
This PR upgrades Ghost to 3.0 and adds the new Lyra theme as a default (for membership sites).
You can check out a demo app running on Heroku here! https://ghost3-test.herokuapp.com/
Hi @cobyism, would you be up for adding me as a maintainer so I can merge this PR and help keep this project up to date?
Hey @nprail as of now this isn't working for me. I'm getting this error:
2020-07-07T17:32:16.830172+00:00 app[web.1]: > [email protected] start /app
2020-07-07T17:32:16.830172+00:00 app[web.1]: > node server.js
2020-07-07T17:32:16.830173+00:00 app[web.1]:
2020-07-07T17:32:16.927769+00:00 app[web.1]: internal/modules/cjs/loader.js:1154
2020-07-07T17:32:16.927770+00:00 app[web.1]: throw new ERR_REQUIRE_ESM(filename, parentPath, packageJsonPath);
2020-07-07T17:32:16.927771+00:00 app[web.1]: ^
2020-07-07T17:32:16.927771+00:00 app[web.1]:
2020-07-07T17:32:16.927788+00:00 app[web.1]: Error [ERR_REQUIRE_ESM]: Must use import to load ES Module: /app/node_modules/oembed-parser/index.js
2020-07-07T17:32:16.927788+00:00 app[web.1]: require() of ES modules is not supported.
2020-07-07T17:32:16.927791+00:00 app[web.1]: require() of /app/node_modules/oembed-parser/index.js from /app/node_modules/ghost/core/server/overrides.js is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
2020-07-07T17:32:16.927793+00:00 app[web.1]: Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /app/node_modules/oembed-parser/package.json.
I think this happened in Node 12.16 when ESM was turned on by default. It seems to be a configuration bug in oembed-parser which was fixed in a later release. Upgrading to latest Ghost fixed it. Would you like me to send you a PR to update this branch?
@paulmelnikow I just pushed a fix. Updating to the latest Ghost did solve the issue.
Thanks!