vda-5050-lib.js icon indicating copy to clipboard operation
vda-5050-lib.js copied to clipboard

Cancelling inactive mission doesnt trigger onOrderProcessed again

Open cmraaron opened this issue 1 year ago • 0 comments

Given an active but processed order, onOrderProcessed handler is called and isOrderProcessedHandlerInvoked is assigned true But later the order may transition isActive from false to true, eg, by way of a cancel instant action

onOrderProcessed is not called again with the updated isActive state, but I'd expect it to be. calling onOrderProcessed is prevented by checking isOrderProcessedHandlerInvoked here https://github.com/coatyio/vda-5050-lib.js/blob/4d2f70f93cb7aecb37944d6523099380c8ada17d/src/controller/master-controller.ts#L688

cmraaron avatar Aug 25 '23 11:08 cmraaron