projects icon indicating copy to clipboard operation
projects copied to clipboard

README.md: Fix broken image on GitBook

Open neelanshsahai opened this issue 7 years ago • 10 comments

Add a link of the image to the Readme so that the Image renders correctly on both, the README and the GitBook Fixes https://github.com/coala/projects/issues/398

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

  • [x] I read the commit guidelines and I've followed them.
  • [x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

neelanshsahai avatar Nov 07 '17 06:11 neelanshsahai

Done !!! :+1:

neelanshsahai avatar Nov 07 '17 09:11 neelanshsahai

ack 5c41e86

prashant0598 avatar Nov 08 '17 12:11 prashant0598

ack 55f495d

prashant0598 avatar Nov 08 '17 20:11 prashant0598

@neelanshsahai , did you try https://github.com/coala/projects/issues/398#issuecomment-341290851 ?

An absolute URL is not a very good solution.

jayvdb avatar Nov 09 '17 18:11 jayvdb

unack 55f495d

jayvdb avatar Nov 09 '17 18:11 jayvdb

Also, in your commit message, it should be GitBook, not gitbook . Please pay attention to details like that.

jayvdb avatar Nov 09 '17 18:11 jayvdb

okay will do that right away :+1:

neelanshsahai avatar Nov 09 '17 19:11 neelanshsahai

@prnvdixit Done :+1: @jayvdb I tried center aligning the images using the markdown syntax, but had no luck. Hope it gets rendered on the GitBook correctly. Also please tell me why is the gem installation failing? (in the deploy preview)

neelanshsahai avatar Nov 11 '17 20:11 neelanshsahai

I doubt we can make image in gitbook readme (About) centered. Seems like the sanitization filter used is strict.

But, for github readme and gitbook html (Introduction), current workaround is enough.

@jayvdb

mamat-rahmat avatar Nov 23 '17 17:11 mamat-rahmat

@mamat-rahmat , we could add a symlink to the screenshot folder, if that would fix it.

@neelanshsahai , you want to try it (create your own custom gitbook with your fork of this repo)

jayvdb avatar Mar 09 '18 04:03 jayvdb