Proper mobile view of About page.

[AkshJain99]

Mobile view of about page looks fine now by adding scrolling feature.

Fixes https://github.com/coala/landing-frontend/issues/298

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

• [x] I read the commit guidelines and I've followed them.
• [x] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

• pick up any PR at https://coala.io/review
• review it (check https://coala.io/reviewing for more info)
• if you are sure that it needs work, use cobot mark wip <URL> to get it out of the review queue.

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

[AkshJain99]

@hemangsk please review this pr

[AkshJain99]

@bharatpurohit97 really but in coala css i think there isno such thing which let me to fix this issue

[AkshJain99]

and also @bharatpurohit97 changes done in coalaCSS is not reflected in coala frontend then how can we change there without observing those changes locally

[frextrite]

I too agree, if it's a vendor CSS file, do not modify it. Instead, change the element class in the HTML file and override the style in custom CSS.

[AkshJain99]

@frextrite but i wanna to ask that how the changes done in coalacss will reflect in coala frontend when run locally

[AkshJain99]

@frextrite I am not getting if i cant change vendor file then what is the otherway through which i can change the style? becoz changes done in coalacss will not reflect in frontend

[TravisBuddy]

Travis tests have failed

Hey @AkshJain99, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
Executing section linecount...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/partials/tabs/about.html
|    |++++| /app/partials/tabs/about.html
| 129| 129|   $('ul.tabs').tabs();
| 130| 130| });
| 131| 131| </script>
| 132|    |-<link rel="stylesheet" href="/resources/css/people.css">
|    | 132|+<link rel="stylesheet" href="/resources/css/people.css">
[INFO][14:56:34] Applied 'ShowPatchAction' on 'partials/tabs/about.html' from 'SpaceConsistencyBear'.
Executing section html...
Executing section yml...
Executing section cli...

TravisBuddy Request Identifier: 9788f440-180c-11e9-982a-45f784180d69

[AkshJain99]

What problem u r getting @utkarsh2102 ?

[TravisBuddy]

Travis tests have failed

Hey @AkshJain99, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci

Unable to find image 'coala/base:latest' locally
latest: Pulling from coala/base
















Digest: sha256:125d6cf24929d39db47b3ccd83d6ed1b6a231fc7e8afbf70bc4b5bd87653b0ff
Status: Downloaded newer image for coala/base:latest
Executing section global...
Executing section linecount...
Executing section spacing...
|    | [NORMAL] SpaceConsistencyBear:
|    | Line contains following spacing inconsistencies:
|    | - No newline at EOF.
|----|    | /app/resources/css/people.css
|    |++++| /app/resources/css/people.css
|  63|  63|     max-height: 80%;
|  64|  64|     overflow: scroll;
|  65|  65|   }
|  66|    |-}
|    |  66|+}
[INFO][07:07:08] Applied 'ShowPatchAction' on 'resources/css/people.css' from 'SpaceConsistencyBear'.
Executing section html...
Executing section yml...
Executing section cli...

TravisBuddy Request Identifier: 2d687e40-1894-11e9-8383-81bede5545a8

[AkshJain99]

It’s not recommended to change materialize css class explicitly. I will recommend you to add a new class in div And add overflow Or any other property in it.

but @KVGarg yes i know that but where did i changed materialise css? i did that earlier but i think now its perfect

[KVGarg]

.card.small .card-content, .card.medium .card-content, .card.large .card-content This constitutes many of materialize css card classes. You are adding or modifying existing css.