landing-frontend icon indicating copy to clipboard operation
landing-frontend copied to clipboard

docs.coala.io: Header's aspect ratio not consistent (in mobile browsers)

Open shashank-b opened this issue 6 years ago • 6 comments

Overview Description

The coala header in https://docs.coala.io/en/latest/ gets scaled only horizontally when viewed using mobile browsers leading to a distortion of the logo. It would be better if the consistency of the logo is maintained, else the koala bear starts looking like a starved chipmunk :smile:

Steps to Reproduce

  1. Open https://docs.coala.io/en/latest/ in any mobile web browser (portrait mode)

Actual Results

Header distortion

Expected Results

If the image scales while preserving aspect ratio and is aligned to the center or to the left, the logo would remain round.

shashank-b avatar Jan 09 '19 10:01 shashank-b

Something like this could also be done (source: webservices.coala.io on a mobile browser): Good Header

shashank-b avatar Jan 10 '19 13:01 shashank-b

Sir can I work on this issue.

Anmolbansal1 avatar Jan 11 '19 13:01 Anmolbansal1

Hi @Anmolbansal1. Please go through the Newcomers' Guide, read it, get an invite and then a maintainer would assign you the issue. And please don't call anyone Sir/Ma'am at coala :slightly_smiling_face:.

shashank-b avatar Jan 11 '19 15:01 shashank-b

I have gone through Newcomers' Guide and want to work on this issue for my newcomer pr. I have sent Hello World to the gitter channel but hadn't received invitation mail yet.

Anmolbansal1 avatar Jan 11 '19 19:01 Anmolbansal1

@shashank-b @li-boxuan please review my pr related to this issue.

Anmolbansal1 avatar Jan 19 '19 19:01 Anmolbansal1

As per the last discussion that I remember (Don't remember which channel or issue), the idea was to create an SVG version of coala-header and sync it with the repo which is using PNG version of coala-header. I have already added the SVG version of coala-header.

sangamcse avatar Feb 04 '19 07:02 sangamcse