gci-leaders icon indicating copy to clipboard operation
gci-leaders copied to clipboard

Getting perfect Lighthouse score

Open blazeu opened this issue 7 years ago • 7 comments

Lighthouse analyzes web apps and web pages, collecting modern performance metrics and insights on developer best practices.

https://github.com/GoogleChrome/lighthouse

This is our current Lighthouse audit result: https://u.teknik.io/4SV0f.html

This task is for increasing our Lighthouse score, multiple students can take this task.

For now, don't worry about service worker / offline support, I think we will have another task for that.

Your build must be rebased and have at least one more audit passed than master.

blazeu avatar Dec 09 '17 14:12 blazeu

u.teknik.io/4SV0f.html

connection failure. They fail too?

jayvdb avatar Dec 09 '17 15:12 jayvdb

Can I take the Best Practises and Accessibility? I could also try my best at Performance.

For GCI task

myfrom avatar Dec 10 '17 18:12 myfrom

@myfrom Sure.

blazeu avatar Dec 10 '17 23:12 blazeu

Just a question: Do you have any favicon? It's not really related to the task but I saw you're setting og:image to GCI logo but leaving favicon blank and I think we could set GCI logo as favicon too.

myfrom avatar Dec 11 '17 16:12 myfrom

Yes, of course.

blazeu avatar Dec 11 '17 16:12 blazeu

I have one more question: I have created favicon.ico, but I'm not sure how to tell the build script to put it into the output, how should I do that?

myfrom avatar Dec 11 '17 19:12 myfrom

Yes, while you're at it, modify it so that it copies the content of static into out/ not out/static so that we're able to put something in the root folder of out such as favicon or manifest.

Don't forget to split your commit accordingly.

blazeu avatar Dec 11 '17 22:12 blazeu