documentation icon indicating copy to clipboard operation
documentation copied to clipboard

FAQ.rst : Adding information about missing test.

Open aliasgar12 opened this issue 6 years ago • 2 comments

Adding review/gitmate/manual/pr to the list of tests that are executed before any pull request is approved. Closes https://github.com/coala/documentation/issues/580

For short term contributors: we understand that getting your commits well defined like we require is a hard task and takes some learning. If you look to help without wanting to contribute long term there's no need for you to learn this. Just drop us a message and we'll take care of brushing up your stuff for merge!

Checklist

  • [x] I read the commit guidelines and I've followed them.
  • [ ] I ran coala over my code locally. (All commits have to pass individually. It is not sufficient to have "fixup commits" on your PR, our bot will still report the issues for the previous commit.) You will likely receive a lot of bot comments and build failures if coala does not pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button. When asked for a rebase, consult coala.io/rebase instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will review your PRs faster!

aliasgar12 avatar Jan 14 '19 03:01 aliasgar12

Hey @aliasgar12 Please run coala on your code and also change your commit message according to the commit guidelines. Besides, the content that you added is also not completely correct. Please read http://api.coala.io/en/latest/Developers/Review.html and look at some currently open or closed PRs for more clarity. (For eg. Not every member can get the PR ready to be merged)

@shashank-b I will fix this and re-commit accordingly. Thanks

aliasgar12 avatar Feb 04 '19 04:02 aliasgar12

Sorry @aliasgar12, you do not have the necessary permission levels to perform the action.

gitmate-bot avatar Feb 04 '19 04:02 gitmate-bot