documentation icon indicating copy to clipboard operation
documentation copied to clipboard

Docker_image.rst: remove pip install instruction

Open vipuldcoder opened this issue 8 years ago • 9 comments

pip install is unnecessary in Docker Image docs.

Fixes https://github.com/coala/documentation/issues/486

vipuldcoder avatar Nov 11 '17 11:11 vipuldcoder

Hello,

Please read the commit guidelines (coala.io/commit) and change your commit message.

For information on how to change your commit message, refer to coala.io/rebase.

yukiisbored avatar Nov 12 '17 16:11 yukiisbored

unack a448fdfc375513f94ab3e0f0057c7e704df46982 @vipuldcoder it would be better if your shortlog and the commit body are visible and same in both, the conversation as well as the commits section :+1:

neelanshsahai avatar Nov 14 '17 12:11 neelanshsahai

@neelanshsahai You don't need to unack just to request changes, use GitHub's feature or just make it a comment. Of course, unack is used when you disagree that this is acceptable and has been ack'd by someone else.

yukiisbored avatar Nov 16 '17 11:11 yukiisbored

@vipuldcoder ugh, the dreaded merge commit.

Anyway to fix this, please do the following:

  1. Create a new branch based of this branch you're using for this PR. git checkout -b <whatever you wanna call>
  2. Make sure you've fetched/pulled the latest master branch. git pull <whatever your remote to the coala repo is> master
  3. Checkout to master. git checkout master
  4. Delete the branch you're using for this PR. DON'T WORRY, GitHub only cares about the branch name, we'll fix it later. git branch -D <the branch name>
  5. Create a new branch based of the latest master with the same name as you're using for this PR. git checkout -b <whatever the name is>
  6. Cherrypick your commit to your new branch. git cherry-pick <the commit hash of whatever you did>
  7. Do a force push to your fork. git push -f -u <whatever your fork remote is> <whatever your branch name is>

yukiisbored avatar Nov 19 '17 12:11 yukiisbored

@vipuldcoder please rectify your PR asap Squashing the commits and updating your Shortlog and Commit Body would be great. :+1:

neelanshsahai avatar Jan 17 '18 19:01 neelanshsahai

@gitmate-bot rebase

jayvdb avatar Apr 28 '18 01:04 jayvdb

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:

gitmate-bot avatar Apr 28 '18 01:04 gitmate-bot

Automated rebase with GitMate.io was successful! :tada:

gitmate-bot avatar Apr 28 '18 01:04 gitmate-bot

Please fix your commit message to abide by http://coala.io/commit . Otherwise we will close this PR as abandoned.

jayvdb avatar Apr 28 '18 01:04 jayvdb