corobo icon indicating copy to clipboard operation
corobo copied to clipboard

Published 20 hours ago • verified publisher icon coala

Make LabHub is_room_member a private function of the module

Open jayvdb opened this issue 6 years ago • 3 comments

LabHub.is_room_member is unnecessarily a static method of the class.

It can be moved to a private function _is_room_member at the module level, and then the tests can be improved to remove the need to do special plugin mocking.

See https://github.com/coala/corobo/pull/572#discussion_r206302575 for context

jayvdb avatar Aug 05 '18 03:08 jayvdb