corobo icon indicating copy to clipboard operation
corobo copied to clipboard

Minor refractoring in labhub tests

Open nvzard opened this issue 7 years ago • 11 comments

~~Do minor changes in labhub_tests as asked here https://github.com/coala/corobo/pull/572#pullrequestreview-141693883~~ (see below)

difficulty/low

nvzard avatar Jul 31 '18 10:07 nvzard

i am a beginner, can i help?

ssg2526 avatar Jul 31 '18 14:07 ssg2526

@ssg2526 , have you completed your newcomer issue?

nvzard avatar Jul 31 '18 14:07 nvzard

@nvzard, i was not assigned any issues till now. which issue i should work on?

ssg2526 avatar Aug 01 '18 05:08 ssg2526

@ssg2526 you should get yourself assigned to a difficulty/newcomer issue which you understand. I set the difficulty of this issue as low but gitmate-bot missed it maybe :3 I think this issue would be a little tricky for a newcomer, but if you understand this you can get yourself assigned otherwise look for another newcomer issue :)

nvzard avatar Aug 01 '18 07:08 nvzard

@nvzard, Thanks for the help.

ssg2526 avatar Aug 01 '18 08:08 ssg2526

Specifically

self.assertEqual(self.labhub.TEAMS, self.teams)

This should use assertIs instead of assertEqual

in test_invite_cmd

mock_dict['is_room_member'].return_value = True

it is already True, and this should be removed

jayvdb avatar Aug 05 '18 03:08 jayvdb

@ssg2526 , you have been sent an invite to join @coala . Please accept it so we can assign this issue to you.

jayvdb avatar Aug 05 '18 03:08 jayvdb

@jayvdb, I have joined the coala

ssg2526 avatar Aug 08 '18 04:08 ssg2526

@jayvdb please assign this issue to me

ssg2526 avatar Aug 08 '18 07:08 ssg2526

Assigned. sorry we tend to respond better on gitter

jayvdb avatar Aug 13 '18 13:08 jayvdb

@Makman2 @li-boxuan Please assign me this issue.

sudonitin avatar Jun 25 '19 18:06 sudonitin