coala-quickstart icon indicating copy to clipboard operation
coala-quickstart copied to clipboard

non interactive mode will cause the list of bears to be printed 2 times

Open ishanSrt opened this issue 6 years ago • 2 comments

Once with unusable and the next time after removing the unusable bears

ishanSrt avatar May 07 '18 16:05 ishanSrt

I've played a bit with the printing of bears and I feel there are 3 options for fixing this:

  • Move the printing after the unusable bears are removed
  • Move the printing after the unusable bears are removed but change the message so the user will know that some bears have been removed due to the options he chose
  • Print at the end both the usable and unusable bears, using a different color for unusable bears and specifying that they won't be used due to the options that the user chose

I would prefer options 3 or 2, as the first one may mislead the user into thinking that no other bears are available. What are your thoughts on this?

tallicamike avatar May 17 '18 09:05 tallicamike

I feel that this is a bit over-engineered, but I thought it might be useful for print_relevant_bears to be extensible, also it is more of proof of concept as I haven't yet added testing. Any feedback/review would be greatly appreciated.

tallicamike avatar May 20 '18 18:05 tallicamike