coala-html
coala-html copied to clipboard
coala
Run bower install during pip install
Presently, bower installs dependencies when user runs coala-html first time. We should implement this installation process when user installs coala-html via pip.
Thanks for reporting this issue!
@coala-analyzer/coala-contributors, your aid is required, fellow coalaian. Help us triage and solving this issue!
This issue is absurd. bower install need not be run while installing coala-html. Use of bower is only when user runs coala-html first time - when angular app has been copied.
Closing this issue as it's not required anymore
The reason I thought it makes sense to do bower install with pip install is because installing should happen in one step. I hate downloading "installers" which then again start downloading and installing more stuff
Looks at his windows laptop ...
But that is definitely a user preference. Some people prefer things that install lazily on demand. Hence I had mentioned you may want to have a vote about this.
strongly disagree with this being a user preference, the user installs coala-html and thus wants to use it, we shouldn't defer steps to do them lazily
i.e. I agree very much with abdeali that if possible we should do this upon installation
@AbdealiJK @sils1297 So what happens now is that the user installs coala-html that contains angular packages including bower.json. Now the app requires static files that are being fetched using bower upon bower install. It's essential that those bower components are located within the directory that stores angular app. This particular directory is specified by user only when coala-html is run upon installation.
Thoughts?
Maybe we can download the stuff once and then copy it whenever it's needed.
This is not important and shouldn't be addressed before we get a main version out of the door.
I was looking at code and found that jupyterlab does it in a fairly nice way.
They have some method where if I install from git, the setup.py auto downloads things from bower/node and builds a single JS file.
This JS file is inside the jupyterlab module, and it gets packages with PyPI. So, when running pip install upload and so on, it auto runs bower on the system and only adds the built files in the .tar.gz on PyPI.
Strongly agree that running bower install after pip install is wrong. The pip package creation process should include all dependencies, including any bower components available at the time of release. Those are the versions which it was tested with , and may disappear later (especially as bower is being decommissioned)
