coala-emacs
coala-emacs copied to clipboard
coala
coala command: use --limit-files
Uses --limit-files instead of --files. Also, additional line-start
and line-end regexp patterns.
Comment on 0fd59448cfad4c41e1ff1a2e6b42a88808c311c3, file test/resources/language/pep8.py, line 1.
The code does not comply to PEP8.
PEP8Bear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/test/resources/language/pep8.py
+++ b/test/resources/language/pep8.py
@@ -1 +1 @@
-a = 1 + 1 # <- not PEP8 compliant
+a = 1 + 1 # <- not PEP8 compliant
@sils So this is the separate PR mentioned in https://github.com/coala/coala-emacs/pull/17. This is really how coala should be called in this case - I even vaguely remember you telling me just that during the sprint.
The issue now is that the PEP8 test file causes coala to complain when checking the repo itself. Can you somehow force this to be accepted despite that?
Comment on 0fd59448cfad4c41e1ff1a2e6b42a88808c311c3, file test/resources/language/pep8.py, line 1.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: python.
The issue can be fixed by applying the following patch:
--- a/test/resources/language/pep8.py
+++ b/test/resources/language/pep8.py
@@ -1 +1 @@
-a = 1 + 1 # <- not PEP8 compliant
+a = 1 + 1 # <- not PEP8 compliant
FYI, I am using this on a daily basis and just tried with the most recent PyPI dev version and that works as well. AFAICS, the remaining problem is that gitmate-bot does not honour the "ignore" directive, see also https://github.com/coala/coala-emacs/pull/18#discussion_r129094580.
@fleimgruber you are right, I have an idea to solve gitmate's problem, please see #20, do you think I should reopen it?
@Grox-Ni No. What @jayvdb said in https://github.com/coala/coala-emacs/pull/20#issuecomment-342408430 and following.
@nemaniarjun this is still waiting for feedback on CI failures because of gitmate-bot, see https://github.com/coala/coala-emacs/pull/18#discussion_r129094580.
@fleimgruber @Makman2 I am confused here, which config does gitmate bot use, the one in the PR or the one on master? Also can't we just override the CI so that we can get this merged? (I mean if gitmate uses the coafile from master then we should just merge this)
I believe it takes it from the PR, otherwise you can't fix issues once they are on master.
However I don't see a problem adding the test files to the ignore setting into the coafile if I see it correctly, should be quite straightforward :+1:
Ah sorry haven't read it properly. Let's try to rebase and see if it works. If not, we have to investigate.
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently :warning:
Hm seems the commits are already up-to-date, could you regenerate the commit hash @fleimgruber and repush? --> git commit --amend --no-edit && git push -f
Comment on 0fd59448cfad4c41e1ff1a2e6b42a88808c311c3, file test/resources/language/pep8.py, line 1.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: python.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpan329k2u/test/resources/language/pep8.py
+++ b/tmp/tmpan329k2u/test/resources/language/pep8.py
@@ -1 +1 @@
-a = 1 + 1 # <- not PEP8 compliant
+a = 1 + 1 # <- not PEP8 compliant
Sorry for responding that late, I've become a bit busy and haven't worked through my notification queue^^
And I know the cause: I've actually missed your very first commit in this PR, because it was at the very top of this page. You have to squash the commits, gitmate will do its analysis on each commit and uses the repository state of it. So your commit that added the new filenames in .coafile does not ignore the test file yet and flags a problem.
@Makman2 well, how obvious it is in hindsight... done and gitmate does not complain anymore.
-
Commit message:
- ~~C~~coala :D
- ~~u~~Use
-
I see two commits here:
Uses
--limit-filesinstead of--files. Also, additional line-start and line-end regexp patterns.One change for
--limit-filesand one for the additional patterns.
Thanks for review. I addressed your comments, changed the commit message (typos) and reverted the regexp pattern change. With your consent I would squash.
Alright you can squash ;) Please rectify your final commit message so things like line-end aren't mentioned any more (due to your "revert commit" :) )